search

nodeSolidServer / node-solid-server

Solid server on top of the file-system in NodeJS
https://solidproject.org/for-developers/pod-server
Other
1.78k stars 303 forks source link

Server should include the Last-Modified header #1793

Open csarven opened 1 month ago

csarven commented 1 month ago

Server MUST generate a Last-Modified header field in response to GET and HEAD requests.

https://solidproject.org/ED/protocol#server-last-modified-includes

Servers are strongly discouraged from exposing information beyond the minimum amount necessary to enable a feature.

https://solidproject.org/ED/protocol#exposing-information

So, the implementation should only expose the Last-Modified header when access is granted to the request target, i.e., when user or public has Read access to the resource. This is typically aligned with the 200 response.

csarven commented 1 month ago

The modified timestamp can be easily retrieved using fs.stat and mtime.

Here is a screencast showing an application making use of the header field in one particular way:

https://dokie.li/media/video/dokieli-last-modified.webm

dokieli-last-modified.webm

See also https://github.com/solid/specification/pull/678#issuecomment-2340391802

knishkagithub commented 2 weeks ago

i would like to work in this issue,could you please assign it to me

csarven commented 1 week ago

@knishkagithub , not sure if you got a notification about @bourgeoa assigning this issue to you but all yours now. Thanks!