search

nodeSolidServer / node-solid-server

Solid server on top of the file-system in NodeJS
https://solidproject.org/for-developers/pod-server
Other
1.78k stars 299 forks source link

Normalise unicode for usernames #905

Open Ryuno-Ki opened 5 years ago

Ryuno-Ki commented 5 years ago

See https://github.com/solid/node-solid-server/issues/824#issuecomment-436028869

Basically, follow the lead of Django (web framework, written in Python) when normalising the usernames for slugs. This could please an international audience.

Unicode is hard, so use a lib (see linked comment).

melvincarvalho commented 5 years ago

Could you define username?

The characters used in the webid / subdomain should be alphanumeric with a dash, I think.

The nick and full names in the profile can be full unicode, and I think already are?

Unicode characters in URIs are a phishing vector. Responsible pod providers should avoid.

akuckartz commented 5 years ago

Unicode characters in URIs are a phishing vector.

Can you suggest any references?

melvincarvalho commented 5 years ago

Try a web search for homograph attack.

Ryuno-Ki commented 5 years ago

@melvincarvalho I learned, that the url is built like [username].[hostname].

@akuckartz I think, he's referring to typosquatting.

Ryuno-Ki commented 5 years ago

Ah, like in https://twitter.com/benbjohnson/status/533848879423578112 then