nodeSolidServer / oidc-op

OpenID Connect Provider for Node.js
MIT License
5 stars 7 forks source link

Use of pem-jwk Seemingly unneeded #14

Closed jonassmedegaard closed 5 years ago

jonassmedegaard commented 5 years ago

It seems that the module pem-jwk provides a subset of the functionality also provided by module @trust/keyto pulled in via @trust/webcrypto.

If my guess (based only on superficially reading the documentation of those modules!) is correct, then it seems codebase can be slimmed a bit by refactoring to not use both.

dmitrizagidulin commented 5 years ago

Huh, good catch. I dont think that package is even used anywhere. I suspect it was refactored out but not removed from package.json.

jonassmedegaard commented 5 years ago

Quoting Dmitri Zagidulin (2019-02-04 03:31:08)

Huh, good catch. I dont think that package is even used anywhere. I suspect it was refactored out but not removed from package.json.

Ah, indeed, it is not used anywhere in the code. That was easy :-)

--

dmitrizagidulin commented 5 years ago

pem-jwk dep has now been removed, closing this.