search

nodeSolidServer / solid-auth-client

A browser library for performing authenticated requests to Solid pods
https://solid.github.io/solid-auth-client/
MIT License
95 stars 42 forks source link

app origin as option of popupLogin #130

Open y0va opened 5 years ago

y0va commented 5 years ago

If an app is deployed on a non-solid-server I need to specify it as trusted since NSS5.

If I login using popupLogin to solid.community with popupUri set to the popup.html on my dev NSS server, after login, it asks me to add that dev server to the trusted apps, instead of localhost or the domain of the deployed app.

If I specify the app location as callbackUri, solid.community asks me to add the app location as trusted app, but it also loads that app in the widget, which is probably the expected behavior. But I also couldn't figure out how to use callbackUri properly, as it seems to be undocumented.

So I envision a option appOrigin to tell the IDP wich Uri to add to trusted apps.

jaxoncreed commented 5 years ago

Ah right. It's better not to use the popup uri and instead have the user choose the issuer from your app.

robmccoll commented 5 years ago

Ha - I just ran across this in solid-file-client via solid-ide and filed https://github.com/jeff-zucker/solid-file-client/issues/72 only to come here.

y0va commented 5 years ago

@jaxoncreed: that's not the problem I's like to specify appOrigin not IDP, which does not need to be the same.