nodeSolidServer / solid-auth-client

A browser library for performing authenticated requests to Solid pods
https://solid.github.io/solid-auth-client/
MIT License
95 stars 42 forks source link

Update dependencies #163

Closed michielbdejong closed 4 years ago

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.2%) to 83.889% when pulling 5eef47069040ce18b5b3f2c0d7d19fdd39e7191b on update-deps into f8d53797af61df5a25b70e2b126088041ba1e35a on master.

michielbdejong commented 4 years ago

Flow is complaining about react-dom in demo/index.js. For now, I replaced the // @flow line there with a FIXME comment. fixed

michielbdejong commented 4 years ago

I also had to skip a few tests, and added FIXME comments there, will look into that. fixed

michielbdejong commented 4 years ago

I'm seeing:

Screenshot 2020-07-28 12 55 10

Can reproduce this by running npx serve in ./dist-popup/. Investigating.

michielbdejong commented 4 years ago

https://www.npmjs.com/package/preact-compat

Note: This module is for Preact 8.x and prior - Preact X includes compat by default. For Preact X, please uninstall preact-compat and replace your aliases with preact/compat.

Fixed in 927808d.

michielbdejong commented 4 years ago
Screenshot 2020-07-28 13 35 12

The first warning is probably because it checks whether you're already logged in. The second one seems to be oidc-rp trying to access JWKS.importKeys from jose.

michielbdejong commented 4 years ago

Adding a debug statement to src/JWKSet.js in jose, then:

cd ../jose ; npm run dist ; cd ../oidc-rp ; npm run dist ; cd ../solid-auth-client ; npm run build
michielbdejong commented 4 years ago

It's failing to import each key in https://github.com/solid/jose/blob/master/src/algorithms/RSASSA-PKCS1-v1_5.js#L106 https://github.com/solid/jose/blob/master/src/jose/JWA.js#L90 https://github.com/solid/jose/blob/master/src/jose/JWK.js#L31 https://github.com/solid/jose/blob/master/src/jose/JWKSet.js#L32 Will continue investigating tomorrow.

michielbdejong commented 4 years ago

Fixed in https://github.com/solid/jose/commit/1731c55eb803d7fed746ad6d446955e9fbd40d5a. Next error: 500 response on /register

michielbdejong commented 4 years ago

As discussed in https://solidos.solid.community/Team/SolidOs%20team%20chat/index.ttl#this