search

nodeSolidServer / solid-auth-oidc

OpenID Connect authentication support for the solid-client library
MIT License
11 stars 2 forks source link

loadClient method does not need to return a promise #7

Closed dan-f closed 7 years ago

dan-f commented 7 years ago

https://github.com/solid/solid-auth-oidc/blob/master/src/index.js#L167-L191

dmitrizagidulin commented 7 years ago

The reason loadClient() returns a promise is because of L187 - RelyingParty.from() returns a promise. (And the reason for that is - re-hydrating keys from string into WebCrypto objects is an async operation.)

dan-f commented 7 years ago

I see.