search

nodebox / seed

Procedural Content Generator
https://seed.emrg.be/
MIT License
22 stars 8 forks source link

Unknown sketch should give 404, not "Cannot read property split of undefined" #37

Closed fdb closed 6 years ago

fdb commented 6 years ago

Wheb loading an unknown sketch we do not get a 404 error but a weird JavaScript error.

For example try loading this page:

https://seed.emrg.be/sketch/DOESNOTEXIST

The error looks like the following:

TanviKumar commented 6 years ago

I suppose this can be done by simply checking if it already exists when going through the URL. Can I take this up?

On 23 Feb 2018 19:54, "Frederik De Bleser" notifications@github.com wrote:

Wheb loading an unknown sketch we do not get a 404 error but a weird JavaScript error.

For example try loading this page:

https://seed.emrg.be/sketch/DOESNOTEXIST

The error looks like the following:

https://camo.githubusercontent.com/3101ecf3031036fd1a3b017a691fe08c3a2a403c/68747470733a2f2f7368697075736572636f6e74656e742e636f6d2f38656565386330643632663033313636636230323534313064363532363563662f53637265656e25323053686f74253230323031382d30322d3233253230617425323031352e32332e31362e706e67

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nodebox/seed/issues/37, or mute the thread https://github.com/notifications/unsubscribe-auth/AR21hatmw7k-lofohixrZ2c3lFP3x4T_ks5tXsomgaJpZM4SQ846 .

fdb commented 6 years ago

@TanviKumar sure go ahead. However make sure that this is synced to the new HTTP data interface in #29 .

TanviKumar commented 6 years ago

Will do!

stebanos commented 6 years ago

Fixed in 5c7caf1733