Don't use any-promise - Githubissues

nodeca / probe-image-size

Get image size without full download. Supported image types: JPG, GIF, PNG, WebP, BMP, TIFF, SVG, PSD, ICO.

MIT License

978 stars 77 forks source link

Don't use any-promise #32

Closed oleg-codaio closed 5 years ago

oleg-codaio commented 5 years ago

Don't think there's a reason to use this nowadays. Even https://github.com/kevinbeaty/any-promise says to use native promises.

Sending this out because I got this error in Mocha:

Error: global leak detected: '@@any-promise/REGISTRATION'

puzrin commented 5 years ago

I have no principal objections, but this requires major version bump. Worth to fix pending bug first. Should happen in 1-2 weeks.

puzrin commented 5 years ago

Fixed pending issues. Kick me after 2-4 weeks. Need feedback - is request with last changes stable or we should try upgrade to got again (this change is breaking too).

sayem314 commented 5 years ago

Please fix conflicts and merge

sayem314 commented 5 years ago

@puzrin I see you dropped any-promise. Also, publish this new version to npm maybe?