Add SVG support - Githubissues

nodeca / probe-image-size

Get image size without full download. Supported image types: JPG, GIF, PNG, WebP, BMP, TIFF, SVG, PSD, ICO.

MIT License

979 stars 77 forks source link

Closed puzrin closed 8 years ago

puzrin commented 8 years ago

[x] Need streaming parser
- need quick fail (if data does not starts with <)
- avoid binary to text conversion before quick fail phase
- may be sax could help (after quick fail passed)
[x] Design API to be compatible - SVG can have floating & not numeric size
[x] Should we allow to disable SVG mode?

puzrin commented 8 years ago

Preliminary API suggestions:

Add result.wUnits & result.hUnits (px, em, ...). px everywhere except SVG.
Allow floats for result.width & result.height
Add options param (second) with allowed types list:
- { types: [ 'svg', 'tiff', 'png', 'webp', ...] }
- "jpg png webp"
? Add .default() method: .default({ types: [ 'svg', 'tiff', 'png', 'webp', ...] })