search

nodeca / tabex

Cross-tab message bus for browsers.
http://nodeca.github.io/tabex/
MIT License
219 stars 19 forks source link

DOMContentLoaded fix #15

Closed Kukunin closed 7 years ago

Kukunin commented 7 years ago

Fixes #14

puzrin commented 7 years ago

LGTM.

Just one comment - could you remove /dist folder from your PR and squash all to single commit?

Kukunin commented 7 years ago

Did you mean put /dist to gitignore? there is dist files in master branch, so I just followed the convention. I've added dist to .gitignore but that's not relevant to this PR

About squash - you can do it yourself when you'll be merging this PR: https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-on-github

Kukunin commented 7 years ago

Actually, it think I've understood what you meant - just exclude dist/ folder changes from PR, because you rebuild it yourself.

puzrin commented 7 years ago

Yes, i rebuild those myself

Kukunin commented 7 years ago

ready

puzrin commented 7 years ago

Also, squashing via github leaves garbage in comment. It's better if you do it at your side.

Kukunin commented 7 years ago

done

puzrin commented 7 years ago

Released with your fix. Thanks!