search

nodecg / generator-nodecg

Yeoman generator for NodeCG bundles
16 stars 8 forks source link

Added clarification on Width units #63

Closed TreZc0 closed 6 years ago

TreZc0 commented 6 years ago

This should be sufficient to allow users to get an idea of the width units. A note could be added that these settings can easily be adjusted in the package.json afterwards. resolves #58

Hoishin commented 6 years ago

Can't tell if it's better to write 16 + 144n.... 🙄

TreZc0 commented 6 years ago

144n - 16 right? Should be the same result and probably the least confusing math equation.

Hoishin commented 6 years ago

@TreZc0 I think it's been enough to merge this :P If you have time, would you mind pulling master branch and maybe update the equation?

TreZc0 commented 6 years ago

@Hoishin Should be fine now :)

codecov[bot] commented 6 years ago

Codecov Report

Merging #63 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   82.26%   82.26%           
=======================================
  Files           4        4           
  Lines         141      141           
=======================================
  Hits          116      116           
  Misses         25       25
Impacted Files Coverage Δ
generators/panel/index.js 77.55% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79816d7...4c746ef. Read the comment docs.

Hoishin commented 6 years ago

Thank you!