search

nodecg / generator-nodecg

Yeoman generator for NodeCG bundles
16 stars 8 forks source link

Update dependencies / convert to ES-Modules #79

Closed SimonFischer04 closed 1 year ago

SimonFischer04 commented 1 year ago

Resolves: #78

SimonFischer04 commented 1 year ago

INFO: still trying to figure out what the hell is wrong with the windows build...

SimonFischer04 commented 1 year ago

So after struggling with this more: unfortunately I was not able to fix it.

The problem on Windows is that the prompts get stuck during testing (but work when running the generator myself!) There seem to be quite some issues around surrounding this. For example: https://github.com/yeoman/yeoman-test/issues/43, https://github.com/SBoudrias/Inquirer.js/issues/767. Some of them might suggest it was (partially for one version) fixed? I mean, yes, running the generator works, but something is broken during the mocha testing environment. To be honest. Looking through all of this over the last few hours, I don't how it every worked. maybe some very specific combination of dependencies that somehow worked.

Ideas on how to continue: a) obviously: somehow fix it - but how??? b) support generation using arguments and not run the prompts on windows?: c) ...

b) Why I would be fine with this option (would this also be acceptable for you?): 1) Checking if this generator prompts correctly would still be done by linux and mac test. It should be yeoman-test's responsibility to check cross-plattform compatibility of this .withPrompts() function 2) everything of Generator (except prompt) is still beeing tested on Windows. 3) as least resort user could always use command line options to generate, if for some reason it broke anyways (however thats possible)

c) Feel free to comment any other ideas / suggestions / ... Best would of course be that i missed something obvious and someone can get it to work 🙂.

SimonFischer04 commented 1 year ago

I was not able to fix it.

I will probably still do some more testing tomorrow. Just wanted to give an update here and ask for suggestions.

SimonFischer04 commented 1 year ago

just tested with bash, still not working, unfortunately.

So i guess I'm fine with just disabling the windows test for now. (Although I may add argument support anyways sometime, because this would allow better integration into other tools - but then in another PR)

SimonFischer04 commented 1 year ago

sorry, accidentally leaked my testing into master branch, reverted it

SimonFischer04 commented 1 year ago

I would be done with testing / changes from my side.

Anything else required?