search

nodecg / generator-nodecg

Yeoman generator for NodeCG bundles
16 stars 8 forks source link

Feat/buildtest #83

Closed SimonFischer04 closed 1 year ago

SimonFischer04 commented 1 year ago

Now to this actual issue that lead me to this refactoring ;).

Resolves: https://github.com/nodecg/generator-nodecg/issues/82 and in the process add a test that should prevent something like this in the future by adding a test that actually tries to build the typescript bundle.

And also addresses some parts of: https://github.com/nodecg/generator-nodecg/issues/81. Namely:

Why draft: I still need to investigate why on my testing PR (https://github.com/SimonFischer04/generator-nodecg/pull/3) now some other test randomly times out on MacOS node16, without changing anything.

SimonFischer04 commented 1 year ago

Ok, apparently everything works fine here and this is just a weird issue on my fork.