search

nodecraft / spawnpoint

Agnostic JS framework that empowers devs to focus on quickly building apps, rather than application config, structure, health-checks, or architecture to build a 12 factor app in Docker.
MIT License
8 stars 5 forks source link

An in-range update of strip-json-comments is breaking the build 🚨 #58

Closed greenkeeper[bot] closed 4 years ago

greenkeeper[bot] commented 4 years ago

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

The dependency strip-json-comments was updated from 3.0.1 to 3.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

strip-json-comments is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ✅ **coverage/coveralls:** First build on greenkeeper/strip-json-comments-3.1.0 at 90.203% ([Details](https://coveralls.io/builds/29870902)). - ❌ **Node 12 macOS-latest Test:** There are 1 failures, 0 warnings, and 0 notices. - ❌ **Node 10 macOS-latest Test:** There are 2 failures, 0 warnings, and 0 notices. - ✅ **Node 12 windows-latest Test:** null - ✅ **Node 10 windows-latest Test:** null - ✅ **Node 12 ubuntu-latest Test:** null - ❌ **Node 10 ubuntu-latest Test:** There are 2 failures, 0 warnings, and 0 notices.
Release Notes for v3.1.0
  • Strictly validate that the jsonString argument is a string 681f8b8

v3.0.1...v3.1.0

Commits

The new version differs by 4 commits.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 4 years ago

After pinning to 3.0.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.