Base config and file names.

nodefluent / kafka-streams

equivalent to kafka-streams :octopus: for nodejs :sparkles::turtle::rocket::sparkles:

https://nodefluent.github.io/kafka-streams/

MIT License

830 stars 111 forks source link

Base config and file names. #160

Closed rob3000 closed 4 years ago

rob3000 commented 4 years ago

Hi Guys,

So after doing: https://github.com/nodefluent/node-sinek/pull/154 there was a lot to review. So this time i thought it would be easier to split it up. This is the first PR to move to typescript.

Renamed files .js -> .ts
Added eslint
Fixed es6 import and exports.

Next steps:

Fix actual types.
Fix tests to work with typescript.

Apologies @wtrocki if i'm stepping on toes with this PR.

wtrocki commented 4 years ago

When renaming git will keep original history. The way this changes were done it creates new files instead of renames. Also not the way I would suggest this to approach it. The best way IMHO will be to move one file at the time - with useJs: true. Done migration many times. I have spent couple hours fixing tests and typings. You are free to take over this issue and contribute something meaningful, no problem, but -100 on approach in this PR.

rob3000 commented 4 years ago

okay. will close this and approach this differently.

wtrocki commented 4 years ago

Perfect! Let's collaborate on this no worries

rob3000 commented 4 years ago

What's the best way to collaborate on this?

wtrocki commented 4 years ago

If you want to start fresh feel free to do so. There will be a lot of files to move so we can jump into those etc. Back from holidays next week