Add metadata props utility

alifahrri commented 3 years ago

Type of changes

Please check the type of change your PR introduces: - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior?

close [issue number]

Related issues :

What is the new behavior?

-

Checklist

[ ] Unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have filled the [Unreleased] Changelog

alifahrri commented 3 years ago

I think to embed metadata, it would be much more clear to user if we also add the functional version to EmbedModelProperty

ok seems nice

alifahrri commented 3 years ago

@triwahyuu seems like i have many branch blocked by this PR, can I fix some issue here

add negative testing for test_embed_class_names
also add the functional version of EmbedModelProperty
more testing related fixes

on another PR?

triwahyuu commented 3 years ago

sounds good to me.

alifahrri commented 3 years ago

sounds good to me.

thanks @triwahyuu, and I'll also update on parser on the next PR

nodefluxio / vortex