search

nodefluxio / vortex

A Deep Learning Model Development Framework for Computer Vision
27 stars 6 forks source link

[BUG] It seems that the size formatting is only for NWHC, NCHW is not supported #119

Open kurnianggoro opened 3 years ago

kurnianggoro commented 3 years ago

https://github.com/nodefluxio/vortex/blob/9eadc6fa50c9d53ca51e63ec522fde55e77dd818/src/runtime/vortex/runtime/onnx/onnxruntime.py#L118

n, w, h, c = size if size[-1]==3 else tuple(size[i] for i in [0,3,1,2])

size is in nwhc format, assume size=[1,32,32,3] then n,w,h,c is correct size is in nchw format, assume size=[1,3,32,32] then n=size[0]=1 w=size[3]=32 h=size[1]=3 c=size[2]=32

It seems that the command size[i] for i in [0,3,1,2] will produce correct result only when the input size is in NWHC format. Thus, both of the conditions are for NWHC format

triwahyuu commented 3 years ago

oh yeah you are right @kurnianggoro, seems like we need more tests on this

alifahrri commented 3 years ago

i thought we standardized the input to be NHWC @triwahyuu ?