nodefluxio / vortex

A Deep Learning Model Development Framework for Computer Vision
27 stars 6 forks source link

Add dali loader aug #38

Closed alphinside closed 4 years ago

alphinside commented 4 years ago

Type of changes

Please check the type of change your PR introduces: - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [x] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [x] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? No support yet for nvidia DALI augmentations - close #21 ## What is the new behavior?
triwahyuu commented 4 years ago

what is the difference between 'BasicDatasetWrapper' and 'DefaultDatasetWrapper'?

alphinside commented 4 years ago

what is the difference between 'BasicDatasetWrapper' and 'DefaultDatasetWrapper'?

BasicDatasetWrapper only do type checking and dataformat checking, DefaultDatasetWrapper add augmentation on it ( Pytroch style ) , while DALI add augmentation on the dataloader ( not recommended but visible )

alphinside commented 4 years ago

any further review guys? @alifahrri @triwahyuu