Support for DETR model - Githubissues

triwahyuu commented 4 years ago

Type of changes

Please check the type of change your PR introduces: - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): closes #25 ## Checklist

[x] Unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules
[x] I have filled the [Unreleased] Changelog

alphinside commented 4 years ago

Got error when trying to train using FrontalFDDBDataset with 1 class

  File "/home/nodeflux/.virtualenvs/vortex/lib/python3.6/site-packages/vortex/development/utils/data/collater/detr.py", line 46, in create_collater
    return DETRColatte(*args, **kwargs)
  File "/home/nodeflux/.virtualenvs/vortex/lib/python3.6/site-packages/vortex/development/utils/data/collater/detr.py", line 9, in __init__
    for k,val in dataformat.items()}
  File "/home/nodeflux/.virtualenvs/vortex/lib/python3.6/site-packages/vortex/development/utils/data/collater/detr.py", line 9, in <dictcomp>
    for k,val in dataformat.items()}
AttributeError: 'NoneType' object has no attribute 'items'

I think the problem is the collater need to handle if the data_format is None, as in the case of landmark detection where the class_label is None ( means the dataset only have 1 class )

fixed in https://github.com/nodefluxio/vortex/pull/43/commits/55d59038dd4cec7f86f7d85ab8b8be7a2dced7cd

triwahyuu commented 4 years ago

okay

alphinside commented 4 years ago

LGTM

triwahyuu commented 4 years ago

ready to be merged

nodefluxio / vortex

Support for DETR model #43

Type of changes