nodefluxio / vortex

A Deep Learning Model Development Framework for Computer Vision
27 stars 6 forks source link

Refactor vortex runtime #47

Closed alphinside closed 4 years ago

alphinside commented 4 years ago

Type of changes

Please check the type of change your PR introduces: - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [x] Refactoring (no functional changes, api changes) - [ ] Build related changes - [x] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? Currently vortex_runtime is tightly coupled to vortex this needs to be updated so vortex_runtime can be a lightweight package, but vortex still need to be depend on it - In current progress, already refactor IRPredictionPipeline._runtime_predict to be embedded in BaseRuntime __call__ method, so right now it is possible to independently use model from create_runtime_model directly easily - close #10 ## What is the new behavior?

Checklist

alphinside commented 4 years ago

ready to review guys @alifahrri @triwahyuu

alphinside commented 4 years ago

additional comment:

  • I prefer if we use src for the main code directory, instead of packages as if more often used.
  • I prefer to use relative import in all the code as much as we can, for the reason already explained.
  • it would be easier if we put the public API from the core/factory.py to the main vortex.development init, so we could just do from vortex.development import create_dataset for example.