nodefluxio / vortex

A Deep Learning Model Development Framework for Computer Vision
27 stars 6 forks source link

Add disable image auto padding #49

Closed alphinside closed 4 years ago

alphinside commented 4 years ago

Type of changes

Please check the type of change your PR introduces: - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? There is no mechanism to disable standard augmentations which enforce padding to square - close #48 ## What is the new behavior?

Checklist

alphinside commented 4 years ago

I think it would be simpler if all collater object is initiated with disable_image_auto_pad, so when the collater object does not have the variable, it is added in create_collater with value of False

Would be nice if we have basecollater but currently we didn't have it, and still with this create_dataset need to be invoked 2 times

triwahyuu commented 4 years ago

I think it would be simpler if all collater object is initiated with disable_image_auto_pad, so when the collater object does not have the variable, it is added in create_collater with value of False

Would be nice if we have basecollater but currently we didn't have it, and still with this create_dataset need to be invoked 2 times

you can specify it from create_collater right? I mean if the collater object does not have the variable, then define it there