save model with best metric in training

triwahyuu commented 4 years ago

Type of changes

Please check the type of change your PR introduces: - [x] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): close #42 ## What is the new behavior?

adding save_best_metrics in config
save checkpoint model with best metric from the save_best_metrics config
not saving model on hyperparameter optimization

Checklist

[ ] Unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules
[x] I have filled the [Unreleased] Changelog

alphinside commented 4 years ago

lgtm, updated docs, please review @triwahyuu

triwahyuu commented 4 years ago

LGTM, ready for merge @alphinside

nodefluxio / vortex

save model with best metric in training #55

Type of changes

Checklist