[BUG] Dataset is not registered

[internnos]

Describe the bug Dataset cannot be registered

To Reproduce Steps to reproduce the behavior:

1. Pull latest image from docker pull nodefluxio/vortex:latest
2. Download dataset from https://gitlab.com/nodefluxio/dataset-repository/image-classification/liveness
3. $ vortex Expected behavior Liveness dataset is registered

Screenshots

Additional context Add any other context about the problem here.

[triwahyuu]

I haven't reproduce your issue, but can I know where did you put your dataset?

[internnos]

You can get the dataset from here

[triwahyuu]

no no, I mean the path where you put the dataset inside the docker container.
currently the dataset only reads in external/datasets relative to where you call the vortex cli. you can also put your dataset directory path to an environment variable, but I forgot the name of the variable, let me look it up.

[triwahyuu]

the environment variable name is VORTEX_DATASET_ROOT

[internnos]

im sorry i got it all wrong. i already put it in external/datasets as mentioned on the docs but the vortex still skip my dataset

[triwahyuu]

ohh I see, let me try to reproduce it tonight then.

[triwahyuu]

I found the problem, it is your dataset that doesn't meet vortex's requirement.
To be found by vortex, your dataset definition should contain 3 things at the same file: dataset class definition, supported_dataset variable (list) which describes all of the available dataset class in the file, and create_dataset function that which returns the dataset object.

I have fixed your implementation and made a PR on it. check it out.

[triwahyuu]

I think we need to add support for dataset registration decorator, cc @alifahrri

[internnos]

@triwahyuu thanks a bunch! I'd check on it

[internnos]

Works like a charm. Thanks a lot!