nodefluxio / vortex

A Deep Learning Model Development Framework for Computer Vision
27 stars 6 forks source link

Refactor onnx graph ops function & registry #96

Closed alifahrri closed 3 years ago

alifahrri commented 3 years ago

Type of changes

Please check the type of change your PR introduces: - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior?

Related issues :

What is the new behavior?

-

-

Checklist

triwahyuu commented 3 years ago

there is a good implementation for registry in mmdetection which use mmcv here https://github.com/open-mmlab/mmcv/blob/master/mmcv/utils/registry.py

example usage:

might be a nice reference implementation for a more general registry

alifahrri commented 3 years ago

there is a good implementation for registry in mmdetection which use mmcv here https://github.com/open-mmlab/mmcv/blob/master/mmcv/utils/registry.py

example usage:

* https://github.com/open-mmlab/mmdetection/blob/master/mmdet/models/builder.py

* https://github.com/open-mmlab/mmdetection/blob/master/mmdet/models/detectors/yolo.py

might be a nice reference implementation for a more general registry

ok

triwahyuu commented 3 years ago

maybe in different PR for that, I have temporarily implement that for model registry in pytorch lightning integration

alifahrri commented 3 years ago

maybe in different PR for that, I have temporarily implement that for model registry in pytorch lightning integration

ok

triwahyuu commented 3 years ago

LGTM, sorry I accidentally closed the pr