search

nodegui / qode

DEPRECATED: Please see https://github.com/nodegui/qodejs instead
https://nodegui.github.io/nodegui/#/tutorial/application-architecture?id=qode
92 stars 10 forks source link

Windows: remove openssl-no-asm flag #4

Closed a7ul closed 5 years ago

a7ul commented 5 years ago

Currently we are building with --openssl-no-asm for windows. See build.js. execSync(`python configure --openssl-no-asm --dest-cpu=${target_arch}`, { cwd: "node" });

This is because we have issues with nasm for windows. See here: https://github.com/nodejs/node/blob/master/BUILDING.md#windows

This causes a warning 

WARNING: --openssl-no-asm will result in binaries that do not take advantage                                                     of modern CPU cryptographic instructions and will therefore be slower.                                                  Please refer to BUILDING.md

Hence need to fix this. Make sure this can be made to work in CI also.