search

nodegui / react-nodegui

Build performant, native and cross-platform desktop applications with native React + powerful CSS like styling.🚀
https://react.nodegui.org
MIT License
6.18k stars 171 forks source link

Fix `Image.src` on Windows when it is a local file #363

Closed NinZine closed 2 years ago

NinZine commented 2 years ago

new URL("C:\path\filename.png") is treated as a valid URL, which it is not. phin subsequently tries to fetch it, but phin and centra only supports http and https anyway. Therefore isValidUrl will check also the protocol.

NinZine commented 2 years ago

Fixes #358

a7ul commented 2 years ago

Thanks @NinZine