search

nodegui / react-nodegui

Build performant, native and cross-platform desktop applications with native React + powerful CSS like styling.🚀
https://react.nodegui.org
MIT License
6.18k stars 171 forks source link

Fix `react` conflicting peer dependency with `react-reconciler` #365

Closed NinZine closed 2 years ago

NinZine commented 2 years ago

Reverting back to react@^16.x.x. react-reconciler should be updated separately so that it can safely be used with react@17.x.x.

react-reconciler should be version 0.26.2 and requires some refactoring.

When installing react-nodegui as a dependency. It will yield a warning:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-reconciler@0.25.1
npm WARN Found: react@17.0.2
npm WARN node_modules/react
npm WARN   react@"^17.0.2" from the root project
npm WARN   1 more (@nodegui/react-nodegui)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.13.1" from react-reconciler@0.25.1
npm WARN node_modules/react-reconciler
npm WARN   react-reconciler@"^0.25.1" from @nodegui/react-nodegui@0.13.0
npm WARN   node_modules/@nodegui/react-nodegui
npm WARN
npm WARN Conflicting peer dependency: react@16.14.0
npm WARN node_modules/react
npm WARN   peer react@"^16.13.1" from react-reconciler@0.25.1
npm WARN   node_modules/react-reconciler
npm WARN     react-reconciler@"^0.25.1" from @nodegui/react-nodegui@0.13.0
npm WARN     node_modules/@nodegui/react-nodegui
Dauto98 commented 2 years ago

Hi, right now I still have this issue with react-nodegui@0.13.0 and react@17.0.2. Any progress since then?