search

nodegui / svelte-nodegui-starter

55 stars 8 forks source link

Remove reliance on .sh script #2

Closed jonasgrunert closed 3 years ago

jonasgrunert commented 3 years ago

First of all I want to say, that all of this is very impressive and I am very happy, that such a cool project exists.

I had some problems getting the project of the ground on my Windows system, which had to do with the bash script user in the start script. What I did was just a small hack, which replaces the bash script with a node script, which achieves the same thing.
This is mainly used for me, but maybe wone would want to integrate it nonetheless. I am open for further questions or anything, which may be required to get this to merge.

Have a great day.

jonasgrunert commented 3 years ago

Thank you for being so fast on the review. I double checked and all changes should be implemented by now.

shirakaba commented 3 years ago

Thank you for the PR! I'll add you to the contributors on svelte-nodegui itself later today.

shirakaba commented 3 years ago

Added to Svelte NodeGUI contributors in PR: https://github.com/nodegui/svelte-nodegui/pull/62