search

nodejitsu / kohai

I am kohai. I am a pluggable irc bot for managing real-time data events.
91 stars 17 forks source link

Parse html entities #28

Closed KarbonDallas closed 13 years ago

KarbonDallas commented 13 years ago

Kohai does not parse html entities. I think it should, no?

>, <, etc...

Marak commented 13 years ago

Can you be more specific?

KarbonDallas commented 13 years ago

e.g.

@mikespokefire: Today's task is to conquer Rails `:remote =>` true and to install node.js
Marak commented 13 years ago

Ahh, it should be a trivial fix. I'm not sure where the actual escaping is happening though.

KarbonDallas commented 13 years ago

On twitter.

bmeck commented 13 years ago

https://github.com/bmeck/jsentities require('JS-Entities').html.[en,de]code(...) ?

Should this be optional?

On Sat, May 21, 2011 at 7:40 AM, emilyrose reply@reply.github.com wrote:

Kohai does not parse html entities. I think it should, no?

>, &lt, etc...

Reply to this email directly or view it on GitHub: https://github.com/nodejitsu/kohai/issues/28

KarbonDallas commented 13 years ago

I'm not sure that it's really necessary to worry about much more than <, >. From what I've seen, twitter doesn't escape that which can't be used for injection (and it didn't even do that for a time).