nodejitsu / module-foundry

A web service for building node.js modules that runs on Linux, SmartOS and Windows.
MIT License
80 stars 8 forks source link

Installing devDependencies? #11

Open Southern opened 11 years ago

Southern commented 11 years ago

I had someone send in a ticket earlier today that is having problems with deploying his package. Looking into it, I see that it's trying to install a dependency that is in devDependencies.

His package.json: https://gist.github.com/dhbaird/6d38e1be2856fbd8d1ad jitsu deploy --debug: https://gist.github.com/dhbaird/5b323f73feca44239d14 The ticket: https://nodejitsu.zendesk.com/agent/#/tickets/12779

As you can see in the jitsu deploy --debug, it's trying to use joe@'joe@~1.1.0'. I also noticed that there was another person who experienced a similar error in the module-foundry logs.

However, I'm not sure that the second person's error was due to a devDependency... so I can't say for sure that it's related.

Not exactly sure what's happening.

/cc @indexzero @AvianFlu @bmeck

Southern commented 11 years ago

This just happened again with another person.

His gist: https://gist.github.com/derekpitt/5222412 package.json: https://gist.github.com/derekpitt/5222730 Ticket: https://nodejitsu.zendesk.com/agent/#/tickets/12801

I'm still not seeing anything in the dependencies that should be causing this. In fact, I don't even see anything trying to use ~1.1.0 in the dependencies. It looks like they're all using ~1.1.1. This is exactly the same thing the first person was running into.

Southern commented 11 years ago

Just got another response from the last person.

Hey Colton,

I was actually able to reproduce this locally when I matched your node/npm
versions (0.8.16/1.1.69)

So I started to upgrade npm one version at a time and was able to get
everything installed with no errors when I got to 1.2.1..

Naturally I wanted to know what changed between 1.2.0 and 1.2.1 and the
only commits that had core changes were around caching.. which makes some
sense (https://gist.github.com/derekpitt/5222412#file-error-log-L143)

So any chance of upgrading npm or letting us specify a version in our
package.json?

Thanks!!
-derek
julianduque commented 11 years ago

happened again

https://gist.github.com/joeybaker/2121aa5adafdcc8dc4bf

julianduque commented 11 years ago

Last was because npm-shrinkwrap, it takes precedence and includes devDependencies