search

nodejitsu / nexpect

spawn and control child processes in node.js with ease
http://github.com/nodejitsu/nexpect
Other
290 stars 37 forks source link

add regex support #11

Closed cxyokk closed 10 years ago

cxyokk commented 10 years ago

see #9 Is this ok?

sam-github commented 10 years ago

Its a useful feature, thanks, I'll pull once it has tests and docs.

I'd also suggest using regex.test(), though that's pretty minor.

indexzero commented 10 years ago

@sam-github Another minor thing. This breaks the style of the project. I have an unhealthy hatred of if statements without { and }. I know ... I should see a doctor, but until then: JSHint.

sam-github commented 10 years ago

Fair enough, (though jshint doesn't warn about that) listen to @indexzero, Mr. @cxyokk, and also fix:

lib/nexpect.js: line 15, col 34, Use '!==' to compare with 'null'.
lib/nexpect.js: line 27, col 34, Use '!==' to compare with 'null'.
indexzero commented 10 years ago

JSHint with this .jshintrc does because of this option:

  curly: true

more info: http://jshint.com/docs/options/#curly

This option requires you to always put curly braces around blocks in loops and conditionals.

bajtos commented 10 years ago

Closing in favour of #15