configure env for the spawned process + preserve API compatiblity

nodejitsu / nexpect

spawn and control child processes in node.js with ease

http://github.com/nodejitsu/nexpect

Other

290 stars 37 forks source link

configure env for the spawned process + preserve API compatiblity #4

Closed bajtos closed 10 years ago

bajtos commented 11 years ago

First of all, 587f600 introduced backwards incompatible API change that broke unit-tests. I have changed the order of callback parameters so that the API stays backwards compatible.

The main purpose of this pull request is to allow users to specify their own environment variables.

P.S. I am not able to run the full test suite. I verified my implementation by running individual tests, i.e.

./node_modules/.bin/vows -m 'options.cwd'
./node_modules/.bin/vows -m 'options.env'

sam-github commented 11 years ago

/to @nodejitsu Comments?

Fwiw, I mildly prefer cb(err,status, stdout, stderr) as callback arg sequence... but not unless docs and tests are changed to match.

bajtos commented 10 years ago

We have merged the pull request to our fork. I am closing this pull request unresolved because there was no reply from the project maintainers for several months.

indexzero commented 10 years ago

FYI I remerged this into master from your upstream. @bajtos @sam-github you both have push & pull access now. let me know your npm usernames and I'll add you there as well.

bajtos commented 10 years ago

Nice, thank you. Here are our npm usernames:

https://npmjs.org/~octet https://npmjs.org/~bajtos

indexzero commented 10 years ago

Added. Thanks for taking over maintenance.