search

nodejs-certified-developer / certification

Public facing repository to document and update community on Node.js Certified Developer project development
MIT License
313 stars 42 forks source link

Review Checklist #25

Open davidmarkclements opened 5 years ago

davidmarkclements commented 5 years ago

Please copy the following checklist, paste it into the PR thread and complete when reviewing item PR's:

- [ ] check for typos
- [ ] comprehension – does it make sense, what about to non-native English speakers?
- [ ] files structure - do they match the meta data in the questions markdown doc
- [ ] in the markdown doc, is the goal aligned with task 
- [ ] in the markdown doc, are the correct files hidden 
- [ ] ensure the phase is completed
- [ ] check that the variant number matches the item code
- [ ] assertion code - does it cover all cases/approaches
- [ ] package.json - any stray deps, correctly named etc.
- [ ] is the description correctly duplicated in project folder (IMPORTANT)
- [ ] do supplied answers correctly validate IN NODE 10
- [ ] is the question still relevant in a Node 10 context
vvscode commented 5 years ago

don't you want put it to issue template?

Horaddrim commented 5 years ago

I think this checklist is for the guy who will review the PR, @vvscode, but I think we have to work on an issue template ASAP