nodejs-mobile / nodejs-mobile-react-native

Node.js for Mobile Apps React Native plugin
https://nodejs-mobile.github.io
MIT License
174 stars 42 forks source link

Fallback to supported architectures. Fixes #34 #43

Closed jmatsushita closed 1 year ago

jmatsushita commented 1 year ago

Fixes https://github.com/nodejs-mobile/nodejs-mobile-react-native/issues/34

Add the abiFilters as a fallback in nodejs-mobile-react-native/android/build.gradle file, if project(":app").android.defaultConfig.ndk.abiFilters isn't set.

This is probably the most sustainable fix since it will prioritise the project level setting if it exists and default to the constant if not. It could probably be further improved on to throw an more user friendly error message if "x86" is set at the project level.

staltz commented 1 year ago

Great suggestion, thank you!