search

nodejs-mobile / nodejs-mobile-react-native

Node.js for Mobile Apps React Native plugin
https://nodejs-mobile.github.io
MIT License
174 stars 42 forks source link

fix: NodeJS build for M1 iOS simulator #49

Closed CaryTrivett closed 1 year ago

CaryTrivett commented 1 year ago

this pr is copy from https://github.com/nodejs-mobile/nodejs-mobile-react-native/pull/23 and fix merge conflicts

CaryTrivett commented 1 year ago

To be honest, I don't know much about this project yet. Are there any areas that need to be changed?

ki0 commented 1 year ago

Someone is going to merge this? We are having problems with this.

staltz commented 1 year ago

Checking and testing this PR takes time, and my time is not for free, unfortunately. If it's blocking you, it is not hard to fork the repo and point your package.json dependency to github:MY_ORG/nodejs-mobile-react-native#tag.

My main concern is that this PR is adding a binary, and I wouldn't trust those from strangers, so first we would need a PR on nodejs-mobile/nodejs-mobile to support building the M1 Simulator binary, and then I can make a new version of that package and then use a locally built binary in the style of this n-m-r-n PR, and of course test on my M1 Mac that all this works. Again, unfortunately this is a multi-hour effort and I'm not going to do it on my customer's budgets or my scarce free time.