search

nodejs / CTC

Node.js Core Technical Committee & Collaborators
80 stars 27 forks source link

Protect release branches #116

Closed MylesBorins closed 7 years ago

MylesBorins commented 7 years ago

Should we limit pushing to release branches to release team? I think so!

I think we should protect all release .x branches and only allow release team to push. This will not stop Owners + Admins from pushing FWIW

jasnell commented 7 years ago

SGTM

cjihrig commented 7 years ago

SGTM

mhdawson commented 7 years ago

SGTM

refack commented 7 years ago

@MylesBorins dup of https://github.com/nodejs/CTC/issues/129?

MylesBorins commented 7 years ago

This was not done... we only protected staging branches (which I think we can revert)

gibfahn commented 7 years ago

This was not done... we only protected staging branches (which I think we can revert)

+1 to unprotecting staging branches (because we often need to force-push to them) and protecting release branches.

gibfahn commented 7 years ago

Note: there are SGTMs from @mcollina and @evanlucas in https://github.com/nodejs/CTC/issues/129

MylesBorins commented 7 years ago

This is implemented. All release branches are now locked to the release team (including admins). Staging is no longer protected