nodejs / CTC

Node.js Core Technical Committee & Collaborators
80 stars 27 forks source link

protect release branches #129

Closed MylesBorins closed 7 years ago

MylesBorins commented 7 years ago

We should protect all vX.x release branches to only be pushable by @nodejs/release

there is no reason for anyone else to be pushing to those branches and they shouldn't be able to be force pushed without documentation.

jasnell commented 7 years ago

SGTM

mcollina commented 7 years ago

SGTM

evanlucas commented 7 years ago

I think that's a good idea

Fishrock123 commented 7 years ago

/shrug

seems fine I suppose

MylesBorins commented 7 years ago

/shrug

seems fine I suppose

@Fishrock123 is this a -1? Is there a reason you think this shouldn't happen? This comment isn't really helping to move the conversation forward and I don't see it as particularly productive

refack commented 7 years ago

@MylesBorins AFAIK this was done, or should this still be open?

MylesBorins commented 7 years ago

Lol I duped