Adding @gibfahn to help repo / perhaps give collaborators group access

nodejs / CTC

Node.js Core Technical Committee & Collaborators

80 stars 27 forks source link

Adding @gibfahn to help repo / perhaps give collaborators group access #58

Closed MylesBorins closed 7 years ago

MylesBorins commented 7 years ago

I'm making this issue to document manually adding @gibfahn to the help repo as a collaborator. There are two other individuals who have manually been given these permissions as well.

I would like to suggest that we give collaborator permission to @nodejs/collaborators, allowing people to opt out of notifications but maintain the ability to admin the repo.

Thoughts?

gibfahn commented 7 years ago

More people looking at nodejs/help seems like a good idea to me.

jasnell commented 7 years ago

has this been done yet?

gibfahn commented 7 years ago

I don't think so, looking at https://github.com/orgs/nodejs/teams/collaborators/repositories

EDIT: I do now have edit access to this repo, although I can't work out how. The giving nodejs/Collaborators permissions in nodejs/help is what is outstanding.

targos commented 7 years ago

The "Adding @gibfahn to help repo" part happened. @gibfahn you have been given individual access from https://github.com/nodejs/help/settings/collaboration

I am really +1 on adding nodejs/collaborators to the allowed teams. Currently, only nodejs/evangelism is there. Do we need a formal approval from @nodejs/ctc ?

Trott commented 7 years ago

Do we need a formal approval from @nodejs/ctc ?

Since we don't have (AFAIK) a documented process for adding people to the help repo, I'd say no, it doesn't need formal approval. But some consensus-seeking seems in order.

I'd propose:

tag @nodejs/ctc for comments (oh look at that, already done)
mention it at the CTC meeting that's happening in about 14 hours

If no one objects in either place—that is, if we only have expressions of support along perhaps with some expressions of indifference—that seems to me a reasonable indicator that we have consensus on adding nodejs/collaborators team to the nodejs/help repo.

gibfahn commented 7 years ago

The "Adding @gibfahn to help repo" part happened. @gibfahn you have been given individual access from https://github.com/nodejs/help/settings/collaboration

Ahh okay, I can't see that page (I assume you have to be a nodejs org owner to see it).

addaleax commented 7 years ago

Reading through this thread it looks like we have consensus that this is a good idea, and I don’t think there’s much harm in giving the collaborator group write access. Done!