search

nodejs / CTC

Node.js Core Technical Committee & Collaborators
80 stars 27 forks source link

Buffer constructor: zero-fill in Node.js 8.0.0? #89

Closed Trott closed 7 years ago

Trott commented 7 years ago

@nodejs/ctc Next vote that was started in the CTC meeting. If you are not listed below (or if your vote has changed or been recorded incorrectly), please comment! Thanks!

Should we zero-fill in Node.js 8.0.0?

YES: @jasnell, @fishrock123, @ofrobots, @trevnorris, @mhdawson, @targos, @addaleax, @evanlucas, @cjihrig, @indutny, @thefourtheye, @bnoordhuis, @shigeki

NO: @mscdex, @ChALkeR, @misterdjules

ABSTAIN: @trott @rvagg

MY VOTE DEPENDS ON WHETHER OR NOT WE BACKPORT AND/OR WHICH RELEASE LINES WE BACKPORT TO:

I'll open a separate issue for the question of whether we random-fill. If both pass and there's not consensus over which one to do, we'll have another vote.

indutny commented 7 years ago

YES

Trott commented 7 years ago

With 10 votes in favor, 2 opposed, and 1 abstention, this can be called. The result is: YES.

However, since this issue has only been open for two minutes, I'll leave this open for 24 hours, just in case someone wants to change their vote or their vote has been incorrectly recorded. I encourage people to continue to leave vote comments even though the vote seems decided. It's possible that someone may switch their vote, and then suddenly your additional vote makes all the difference.

misterdjules commented 7 years ago

My vote is no.

rvagg commented 7 years ago

delayed abstain with a slight leaning to yes (i.e. +0)

thefourtheye commented 7 years ago

Yes

bnoordhuis commented 7 years ago

YES

(I don't like to shout.)

Mayhem93 commented 7 years ago

My vote is NO. What would be the purpose of Buffer.prototype.fill then?

addaleax commented 7 years ago

What would be the purpose of Buffer.prototype.fill then?

Quick answer: Fill buffers that were allocated with Buffer.allocUnsafe(Slow), fill them with a different byte value, fill them with repeated instances of a string, only fill part of a buffer with a given value.

But I’d really recommend you to take discussions to https://github.com/nodejs/node/issues/9531, this thread is specifically for CTC members voting, anything else is a bit off-topic…

shigeki commented 7 years ago

Yes

Trott commented 7 years ago

It's been the 24 hours I said I'd wait. This is definitely approved. Final vote count:

YES: 13

NO: 3

ABSTAIN: 2

(CTC members who did not vote or indicate they planned to abstain: 2)

Thanks, everyone!