search

nodejs / TSC

The Node.js Technical Steering Committee
575 stars 127 forks source link

CLI tools behind a Nodejs namespace #1178

Open danielleadams opened 2 years ago

danielleadams commented 2 years ago

Not sure if this is the right place for this issue, so I am happy to move it. I opened it here because it affects multiple tools in the Node.js org.

Since the installation instructions on the Node.js tooling (ie. https://github.com/nodejs/node-core-utils, https://github.com/nodejs/changelog-maker, etc) recommend a global install, should these be put under a Node.js scope on the npm registry such as @nodejs/<packagename>?

It establishes a level of trust in the published packages ("I know this came from the Node org"), and it will hopefully help contributors avoid accidental installations of similarly named packages.

Docs: https://docs.npmjs.com/cli/v8/using-npm/scope

ljharb commented 2 years ago

Perhaps they should also recommend using npx instead, since global installs are widely discouraged in the community.

danielleadams commented 2 years ago

@ljharb yeah, we should probably do both

mmarchini commented 2 years ago

I like the idea of using namespace but would rather not use @nodejs, as that might encourage project specific tools to be used externally, which is not recommended. Something like @nodejs-dev maybe?

mhdawson commented 2 years ago

Or maybe even something more specific like @nodejs-dev-internal ?

mcollina commented 2 years ago

I'm ok to use an org/scope but not @nodejs. I'm ok with @nodejs-dev but I think @nodejs-core is more explicit in intent.

targos commented 2 years ago

I like @nodejs-core or @node-core.

node-core-utils could be renamed to @node-core/utils

mcollina commented 2 years ago

@node-core/utils has a nice sound.

MylesBorins commented 2 years ago

+1 for @node-core

it looks like the scope is currently being squatted but if someone opens a ticket with npm support (shouldn't be me) I can look into getting us access

mhdawson commented 1 year ago

@MylesBorins created this ticket - https://support.github.com/ticket/personal/0/2095597

danielleadams commented 1 year ago

I think that was me that squatted on it shortly after we discussed initially. Never got around to moving this forward, but I can unsquat so we can use it.

Ethan-Arrowood commented 1 year ago

Relative to the thread I just opened on admin (https://github.com/nodejs/admin/issues/794) I like the idea of dev-related stuff being published under a different scope than public stuff.

Ethan-Arrowood commented 1 year ago

Making a plan to solve this with @danielleadams .

mhdawson commented 1 year ago

I just received notification that node-core was transferred to the nodejs-foundation account. We can now start publishing packages in that namespace.

Ethan-Arrowood commented 1 year ago

Do we have @nodejs too? I don't think its been decided yet what the external scope will be, but i think that one was shared during collab summit

mhdawson commented 1 year ago

Right now we have node, node-core and pkgjs

mhdawson commented 1 year ago

@danielleadams now that we have node-core what are the next steps and does this still need to be on the TSC agenda.

Ethan-Arrowood commented 1 year ago

@mhdawson I think we need to merge https://github.com/nodejs/admin/pull/795 too + make the public facing scope happen

mhdawson commented 1 year ago

Discussed in meeting today. Those in attenance agreed should be ok to start migrating packages to the node-core namespace as we have the namespace and no objections have been raised.

Ethan-Arrowood commented 1 year ago

I'm glad to see @node-core was approved. Can y'all discuss another scope for public facing modules next? Thank you! RE: https://github.com/nodejs/admin/issues/794