search

nodejs / TSC

The Node.js Technical Steering Committee
592 stars 133 forks source link

Annual Report Metrics #157

Closed mikeal closed 7 years ago

mikeal commented 7 years ago

Heya,

The LF is putting together a big report of what the projects have accomplished in the last year. I'm looking to put together info in the following two areas:

Curious what everyone has to say :)

mikeal commented 7 years ago

@nodejs/collaborators ^

bnoordhuis commented 7 years ago

On the main repo, we had roughly 440 contributors between November 1, 2015 and November 1, 2016 compared to 260 over the same period a year earlier, a 70% increase. The number of commits grew from about 2100 to 2850, a 35% increase.

The relative weight in number of commits from the top 10 committers shifted from 52% to 46%, i.e., more work is being done by people outside the top 10 (but absolute numbers are up from 1100 to 1300.)

@Trott is currently the most prolific committer by a significant margin, I'm second, @jasnell third, and @addaleax comes in fourth. That's impressive seeing she only started this year and doesn't work on node.js full-time. (Also fourth by number of Reviewed-By tags, by the way.)

Caveat emptor: I'm only looking at the master branch. Release branches are mostly back-ports from master, they don't contain much original work.

Fishrock123 commented 7 years ago

5393 of our 9476 "issues" are pull requests, still sitting over half at 56.9%

I'd like to get more issue stats but not today.

I suspect things like average PR and Issue open times could be useful.

rvagg commented 7 years ago

Build will provide some stats on the size and scope of our impressive CI cluster. It's worth highlighting (again) how we're doing this under a contribution model—we have one of the most impressive CI clusters of any open source project (I'm not aware of a better one tbh and I'm sure there aren't a whole lot of private ones that are as impressive) but the Foundation has paid exactly $0 for the pleasure of it.

@jbergstroem would you like to start coming up with some metrics?

jbergstroem commented 7 years ago

I'll scribble something together!

ronkorving commented 7 years ago

Perhaps some stats on code coverage would be good to add?

jbergstroem commented 7 years ago

todo - please suggest more!

@nodejs/benchmarking : perhaps some interesting findings from your group? @nodejs/testing : same; people working with tests have done an amazing job - i'd really like to see it represented.

joshgav commented 7 years ago

From the diagnostics WG: async_hooks, v8_inspector, and event_trace projects to make it easier to quickly diagnose and fix problems. Inspector is already in use in Chrome DevTools, VS Code, and IntelliJ WebStorm.

From the post-mortem WG: llnode and nodereport projects.

Also worth mentioning the collaboration with TC39 on dynamic/CommonJS modules in ES.

/cc @mhdawson @nodejs/diagnostics @nodejs/post-mortem

addaleax commented 7 years ago

Perhaps some stats on code coverage would be good to add?

I don’t think I could put it better than @mhdawson in https://github.com/nodejs/nodejs.org/issues/1015#issuecomment-259523790

rvagg commented 7 years ago

I've borrowed some of the data in this thread for my presentation at Node Interactive, "State of the Union: Node.js" and added a bunch more. Will share a PDF when I'm done but I'm also keen to put all of my various scripts in one place to make generation much easier and perhaps automatic.

@addaleax @mhdawson I hacked up addaleax/node-core-coverage to work against a version of Node at the very end of 2015 to compare to today, it's pretty rough and didn't work perfectly but I did get some JS results:  screenshot 2016-11-29 07 15 11

Does that pass the sniff-test for you? We've gone from 84.62% to 89.48% in 2016. Might not sound impressive to most but I'll make sure people know the gravity of any shift in our coverage. /cc @trott

I really like @bnoordhuis' metric of % of commits that the top 10 are responsible for and I'm going to script that up to see what it looks like over time. @bnoordhuis if you have something already that does this then please let me know. This is something we should continue to track as it adds really nicely to the "health" story for Node and should help us keep us focused on the right things.

Some tidbits that I have so far that might be interesting to this group:

jasnell commented 7 years ago

Very awesome to see these numbers

On Mon, Nov 28, 2016 at 2:32 PM Rod Vagg notifications@github.com wrote:

I've borrowed some of the data in this thread for my presentation at Node Interactive, "State of the Union: Node.js" and added a bunch more. Will share a PDF when I'm done but I'm also keen to put all of my various scripts in one place to make generation much easier and perhaps automatic.

@addaleax https://github.com/addaleax @mhdawson https://github.com/mhdawson I hacked up addaleax/node-core-coverage to work against a version of Node at the very end of 2015 to compare to today, it's pretty rough and didn't work perfectly but I did get some JS results:  [image: screenshot 2016-11-29 07 15 11] https://cloud.githubusercontent.com/assets/495647/20684375/bb7dd86a-b603-11e6-8915-fa138b9ab4aa.png

Does that pass the sniff-test for you? We've gone from 84.62% to 89.48% in

  1. Might not sound impressive to most but I'll make sure people know the gravity of any shift in our coverage. /cc @trott https://github.com/trott

I really like @bnoordhuis https://github.com/bnoordhuis' metric of % of commits that the top 10 are responsible for and I'm going to script that up to see what it looks like over time. @bnoordhuis https://github.com/bnoordhuis if you have something already that does this then please let me know. This is something we should continue to track as it adds really nicely to the "health" story for Node and should help us keep us focused on the right things.

Some tidbits that I have so far that might be interesting to this group:

  • 90 collaborators, 48 are active in the codebase in 2016 (not counting GitHub yet, that'll be a nice addition later because it will change that number)
  • Total contributor count is increasing at an accelerating rate
  • Each month is receiving, on average:
    • more than twice the number of new contributors than 2015
    • 1.5 times the number of unique contributors to the codebase compared to 2015
  • Increase in core commits over 2016 of 125%, driven by changes outside of the main source directories, primarily test/ (155%) and doc/ (nearly 200%), in fact commits to src/ and lib/ are down
  • Over 90% of lines of the API documents were changed! (using git so that includes a lot of shuffle)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/TSC/issues/157#issuecomment-263385699, or mute the thread https://github.com/notifications/unsubscribe-auth/AAa2eTx_7y6j8avnHZKq6OUMJJp18u5Nks5rCzpogaJpZM4KgJlZ .

mhdawson commented 7 years ago

Can't really validate your number, but I can believe we have improved coverage that much based on the level of activity we've seen on the tests. In addition to calling that out I think the other major achievement is how much more stable the CI runs are. A lot of work has gone into the tests this year to make that happen.

Regards,

Michael (M.H.) Dawson Runtime Technologies Node.js Technical Lead Software Developer and Master Inventor

Phone: 1-613-356-5484 | Phone: 1-343-882-2473 E-mail: Michael_Dawson@ca.ibm.com Find me on:

3755 Riverside Drive Ottawa, ON K1V 1B8 Canada

From: Rod Vagg notifications@github.com To: nodejs/TSC TSC@noreply.github.com Cc: Michael Dawson/Ottawa/IBM@IBMCA, Mention mention@noreply.github.com Date: 11/28/2016 03:32 PM Subject: Re: [nodejs/TSC] Annual Report Metrics (#157)

I've borrowed some of the data in this thread for my presentation at Node Interactive, "State of the Union: Node.js" and added a bunch more. Will share a PDF when I'm done but I'm also keen to put all of my various scripts in one place to make generation much easier and perhaps automatic. @addaleax @mhdawson I hacked up addaleax/node-core-coverage to work against a version of Node at the very end of 2015 to compare to today, it's pretty rough and didn't work perfectly but I did get some JS results: 

Does that pass the sniff-test for you? We've gone from 84.62% to 89.48% in

  1. Might not sound impressive to most but I'll make sure people know the gravity of any shift in our coverage. /cc @trott I really like @bnoordhuis' metric of % of commits that the top 10 are responsible for and I'm going to script that up to see what it looks like over time. @bnoordhuis if you have something already that does this then please let me know. This is something we should continue to track as it adds really nicely to the "health" story for Node and should help us keep us focused on the right things. Some tidbits that I have so far that might be interesting to this group: 90 collaborators, 48 are active in the codebase in 2016 (not counting GitHub yet, that'll be a nice addition later because it will change that number) Total contributor count is increasing at an accelerating rate Each month is receiving, on average: more than twice the number of new contributors than 2015 1.5 times the number of unique contributors to the codebase compared to 2015 Increase in core commits over 2016 of 125%, driven by changes outside of the main source directories, primarily test/ (155%) and doc/ (nearly 200%), in fact commits to src/ and lib/ are down Over 90% of lines of the API documents were changed! (using git so that includes a lot of shuffle) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
mikeal commented 7 years ago

Now that we are in the new year can we re-run these Jan1-Jan1?

jasnell commented 7 years ago

It's about time to get another update pulled together on this.

jasnell commented 7 years ago

Closing this... tho it would be good to get another run on these metrics