search

nodejs / TSC

The Node.js Technical Steering Committee
591 stars 134 forks source link

Start a vote on require(esm) markers #1621

Closed joyeecheung closed 1 week ago

joyeecheung commented 2 weeks ago

This is a follow-up to the naming bikeshed in https://github.com/nodejs/loaders/issues/221 which is for the implementation in https://github.com/nodejs/node/pull/54563 A summary can be found in https://github.com/nodejs/node/pull/54563#pullrequestreview-2288424604

joyeecheung commented 2 weeks ago

cc @nodejs/tsc @nodejs/loaders @guybedford

joyeecheung commented 1 week ago

I am not entirely sure how long this should wait, https://github.com/nodejs/TSC/tree/main/votes/initiateNewVote#initiate-a-new-tsc-vote just says "Once the PR has approvals", and it's been open for about 2 days with a few approvals, so I guess I'll just merge it when it passes the 48-hour mark.