search

nodejs / abi-stable-node

Repository used by the Node-API team to manage work related to Node-API and node-addon-api
241 stars 34 forks source link

Old issues and PRs on the node-addon-examples #348

Closed NickNaso closed 6 years ago

NickNaso commented 6 years ago

Hi everyone, we are starting to work on examples to the https://github.com/nodejs/node-addon-examples repo. I noted that there are very old issues and PRs on this repo. How should we proceed?

mhdawson commented 6 years ago

I think its worth going through them and either accepting or closing them.

I close a couple.

I think in many cases we could say that the focus of the repo is now N-API examples and therefore the issue is stale, along with the request for the originator to let us know if they dis-agree with closing.

NickNaso commented 6 years ago

Ok thanks I will work as you suggested.