nodejs / abi-stable-node

Repository used by the Node-API team to manage work related to Node-API and node-addon-api
239 stars 47 forks source link

Separate additional package on top of node-addon-api? #363

Closed mhdawson closed 5 years ago

mhdawson commented 5 years ago

Do we need an additional module for extentions to node-addon-api?

For example: https://github.com/nodejs/node-addon-api/pull/377

mhdawson commented 5 years ago

Also https://github.com/nodejs/node-addon-api/issues/439 with part of the context.

Created this issue and added to Milestone 11 so that we review/discuss in the next N-API team meeting.

mhdawson commented 5 years ago

Another one that might be in helper or N-API itself: https://github.com/nodejs/node-addon-api/issues/265

mhdawson commented 5 years ago

From discussion 2 approaches would be:

mhdawson commented 5 years ago

Next steps:

digitalinfinity commented 5 years ago

Here's a first cut on a doc that expands on the problem being covered in this issue and possible solutions: https://docs.google.com/document/d/13DqZUeLjwf09EmkRBBIJkLE2bxmqWt2zF5FoNvHbjZc/edit?usp=sharing

mhdawson commented 5 years ago

PR landed here: https://github.com/nodejs/node-addon-api/pull/477