search

nodejs / abi-stable-node

Repository used by the Node-API team to manage work related to Node-API and node-addon-api
239 stars 47 forks source link

Napi version in node-gyp #371

Closed mhdawson closed 5 years ago

mhdawson commented 5 years ago

For discussion in next meeting:

https://github.com/nodejs/node-gyp/issues/1745

jschlight commented 5 years ago

With node-pre-gyp and prebuild, the N-API version is essentially specified by the user and then the actual N-API version being built against is communicated into the binding.gyp file using a new napi-build-version variable we created for the purpose.

In the linked issue, the user is requesting that node-gyp inform the binding.gyp file which N-API version is supported by the version of Node being built against.

It's like the opposite of what we implemented for node-pre-gyp and prebuild.

richardlau commented 5 years ago

A PR was opened against core: https://github.com/nodejs/node/pull/27800

NickNaso commented 5 years ago

Hi everyone, I closed my previous PR and reopened new one https://github.com/nodejs/node/pull/27835. Please if you have time take a look.

NickNaso commented 5 years ago

Hi everyone, if someone has time could take a look at this PR https://github.com/nodejs/node/pull/27835 in particular the last two comments? I need a feedback.

NickNaso commented 5 years ago

I’m closing this because the PR has been landed yesterday and the work now is on Node.js 12.6.0