search

nodejs / abi-stable-node

Repository used by the Node-API team to manage work related to Node-API and node-addon-api
239 stars 47 forks source link

N-API 6 #393

Closed gabrielschulhof closed 4 years ago

gabrielschulhof commented 4 years ago

The only outstanding backport for new N-APIs is https://github.com/nodejs/node/pull/31384 which brings napi_get_all_property_names to v10.x. Shall we wait until it lands to make off N-API 6 as including napi_get_all_property_names, or shall we leave napi_get_all_property_names experimental and roll N-API 6 without it?

Once we have arrived at a decision, we need to file a PR in core that bumps the NAPI_VERSION and updates the preprocessor if-block into which the N-API declarations are placed.

legendecas commented 4 years ago

Since https://github.com/nodejs/node/pull/31384 has landed on v10.x-staging as https://github.com/nodejs/node/pull/31384#issuecomment-593361988, I'd believe we're going to roll N-API 6 with napi_get_all_property_names if there are no other issues arisen.

mhdawson commented 4 years ago

@gabrielschulhof looks like we are ready to go

gabrielschulhof commented 4 years ago

Excellent!