Enabled debug testing for addons

nodejs / abi-stable-node

Repository used by the Node-API team to manage work related to Node-API and node-addon-api

239 stars 47 forks source link

Enabled debug testing for addons #398

Open mhdawson opened 4 years ago

mhdawson commented 4 years ago

We should look at enabled testing of addons under debug in core.

gabrielschulhof commented 4 years ago

@mhdawson can we add a field to our top-level CI job that would cause it to append --debug to the npm test command line that runs our tests?

mhdawson commented 4 years ago

@gabrielschulhof do you mean an option when you run the job which can add the --debug or not? That might work, although I think in many cases we'd want Node.js to be compiled in debug which will be a challenge since right now we use the existing nightly builds instead of building Node.js

mhdawson commented 4 years ago

I think there is also this issue for adding debug testing in core. https://github.com/nodejs/build/issues/1854

mhdawson commented 4 years ago

Next steps

[x] Enable addon testing in existing debug CI runs - nodejs/build#1854
[ ] Create debug test for node-addon-api in node-addon-testing for single platform (linux) and master of Node.js.
[ ] Consider if we should run on all LTS versions

KevinEady commented 3 months ago

Found issue in node-addon-api: https://github.com/nodejs/node-addon-api/issues/1511