search

nodejs / abi-stable-node

Repository used by the Node-API team to manage work related to Node-API and node-addon-api
240 stars 34 forks source link

Crash reported due to Node.js #34839 #411

Closed mhdawson closed 4 years ago

mhdawson commented 4 years ago

https://github.com/nodejs/node/issues/35620 Reported as being due to: https://github.com/nodejs/node/commit/a6b655614f03e073b9c60f3d71ed884c5af32ffc

mhdawson commented 4 years ago

@gabrielschulhof in case you have a chance to take a look before the meeting on Friday.

mhdawson commented 4 years ago

@gabrielschulhof my first thought is that even if there is no user provided finalizer, we've still set it up for the gc to call a Finalize() in js_native_api_v8.cc and therefore there is a race condition if we delete when reference->_finalize_callback is nullptr.

mhdawson commented 4 years ago

Closing since we discussed, and the revert is in place.