search

nodejs / abi-stable-node

Repository used by the Node-API team to manage work related to Node-API and node-addon-api
239 stars 47 forks source link

Ask for review of node-serialport Node-API port - https://github.com/serialport/node-serialport/pull/2305/files #430

Closed mhdawson closed 2 years ago

mhdawson commented 3 years ago

In https://github.com/serialport/node-serialport/issues/1186#issuecomment-894448550 the OP asked if any of the Node-API team would be able to take a look at:

https://github.com/serialport/node-serialport/pull/2305/files

mhdawson commented 3 years ago

@NickNaso and @KevinEady have started to review, Thanks !

gabrielschulhof commented 2 years ago

The PR was merged and released as 10.0.0 under the beta flag.