search

nodejs / admin

Administrative space for policies of the TSC
155 stars 135 forks source link

Benchmark scripts used by an active Jenkins job are archived #762

Open legendecas opened 1 year ago

legendecas commented 1 year ago

The benchmark job https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/ is using the script https://github.com/nodejs/benchmarking/blob/master/experimental/benchmarks/community-benchmark/run.sh to run the benchmarks.

The script is cloning the repo with the HTTP protocol http://github.com/nodejs/node.git (it's been redirected to use HTTPS protocol automatically). Probably worth updating the script to use HTTPS instead.

However, the repository https://github.com/nodejs/benchmarking has been archived and can not be updated. Should we move the benchmarking scripts to a dedicated repo since the benchmarking working group has been de-chartered?

RafaelGSS commented 1 year ago

What about moving it to node/tools?

legendecas commented 1 year ago

What about moving it to node/tools?

This can be an option. Or we can put it in https://github.com/nodejs/build/tree/main/jenkins/scripts like other Jenkins scripts.

RafaelGSS commented 1 year ago

I think the latter is a good choice, indeed.

cc: @nodejs/build

nschonni commented 1 year ago

There is a PR to remove that stuff from the build repo too https://github.com/nodejs/build/pull/3145

richardlau commented 1 year ago

See also https://github.com/nodejs/build/issues/3277.

We could always unarchive https://github.com/nodejs/benchmarking. Would @nodejs/performance be interested in owning it?

You could open a PR to move the script to https://github.com/nodejs/build/tree/main/jenkins/scripts, but then every change to that script is going to be bottlenecked on the Build WG.

anonrig commented 1 year ago

I think we should keep it under nodejs/build.